[flang-commits] [PATCH] D135835: [flang] Add atomic_cas to the list of intrinsics

Katherine Rasmussen via Phabricator via flang-commits flang-commits at lists.llvm.org
Thu Oct 13 09:38:55 PDT 2022


ktras marked an inline comment as done.
ktras added inline comments.


================
Comment at: flang/lib/Evaluate/intrinsics.cpp:1347
 
+static bool CheckAtomicKind(const ActualArgument *arg,
+    const semantics::Scope *builtinsScope,
----------------
jeanPerier wrote:
> If `arg` must not be a nullptr, better use `const ActualArgument &arg` here and push the responsibility of  passing something non null on the caller. 
Thanks, the changes have been made.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135835/new/

https://reviews.llvm.org/D135835



More information about the flang-commits mailing list