[flang-commits] [PATCH] D135835: [flang] Add atomic_cas to the list of intrinsics

[Jean Perier via Phabricator via flang-commits]

jeanPerier added inline comments.


================
Comment at: flang/lib/Evaluate/intrinsics.cpp:1347
 
+static bool CheckAtomicKind(const ActualArgument *arg,
+    const semantics::Scope *builtinsScope,
----------------
If `arg` must not be a nullptr, better use `const ActualArgument &arg` here and push the responsibility of  passing something non null on the caller. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135835/new/

https://reviews.llvm.org/D135835