[flang-commits] [PATCH] D134970: [flang] Do not resolve TRIM/REPEAT length to its argument length

[Kiran Chandramohan via Phabricator via flang-commits]

kiranchandramohan added a comment.

`pop2` in spec2017 stopped building after this change.

I have a small reproducer. I get the following error

  error: Semantic errors in my_test.f90
  ./my_test.f90:5:12: error: Internal error: Expression analysis failed on: Expr -> ArrayConstructor -> AcSpec
  | AcValue -> Expr -> FunctionReference -> Call
  | | ProcedureDesignator -> Name = 'trim'
  | | ActualArgSpec
  | | | ActualArg -> Expr -> Designator -> DataRef -> Name = 'n'
  
      call sb1((/trim(n)/))

in

  program mn
    character(len=6) :: n
    n = 'hello '
    call sb1((/trim(n)/))
  contains                                 
  subroutine sb1(nm)
    character(*) :: nm(:)
    print *, len(nm(1))
  end subroutine
  end program

It was previously computing an incorrect result. So it is probably not a regression but `pop2` test version used to build and run correctly before this change. Please let me know if you want me to create a github issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134970/new/

https://reviews.llvm.org/D134970