[flang-commits] [PATCH] D134285: [flang][RFC] Adding higher level FIR ops to ease expression lowering

[Jean Perier via Phabricator via flang-commits]

jeanPerier added a comment.

In D134285#3847139 <https://reviews.llvm.org/D134285#3847139>, @schweitz wrote:

> I don't agree that this new dialect should extend FIR. They should be separate dialects.

Thanks for the feedback. I think that was also the consensus in https://reviews.llvm.org/D134285#inline-1294898 discussion. The exception will be fir.declare (where I see advantages to keep it until LLVM codegen to handle things like debug info and allow using Fortran level information (even after inlining) for alias analysis), I agree that it makes sense to put it in a separate dialect. I updated the document to reflect this.

Update the document to reflect that the operations will be added in a new dialect HLFIR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134285/new/

https://reviews.llvm.org/D134285