[flang-commits] [PATCH] D129156: Add -fpass-plugin option to Flang

[Mats Petersson via Phabricator via flang-commits]

MatsPetersson added a comment.

In D129156#3837709 <https://reviews.llvm.org/D129156#3837709>, @awarzynski wrote:

> I suspect that this fails when running `ninja check-flang`, right?
>
> Most likely `Bye` needs to be added as a dependency for Flang tests, something akin to this <https://github.com/llvm/llvm-project/blob/3f078b308bc67d3a05dc0de2588790ed9669febc/llvm/test/CMakeLists.txt#L192-L196>.  Alternatively, try adding `examples` to `! REQUIRES:` in pass-plugin.f90.

As this seems to be breaking the testing on the public servers, as well as locally on my machine, I've reverted the commit for now. Please feel free to submit an updated version, this is not a criticism of the work as such, just trying to keep the "build & test" green.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129156/new/

https://reviews.llvm.org/D129156