[flang-commits] [PATCH] D129156: Add -fpass-plugin option to Flang

Tue Oct 4 11:22:34 PDT 2022

awarzynski accepted this revision.
awarzynski added a comment.
This revision is now accepted and ready to land.

LGTM, many thanks for addressing all my comments and for seeing this through!

In D129156#3833501 <https://reviews.llvm.org/D129156#3833501>, @tarunprabhu wrote:

> I noticed that clang-format changed several other lines in `clang/lib/Driver/ToolChains/Flang.cpp`. I undid those and only left in the line relevant to this patch. Do you think that those lines should be run on that file as a separate patch?

Up to you :) In general, it's good to keep the noise to a minimum. For things like this I would just push a separate patch without a review. Such patches implement non-functional-changes, are rather straightforward and very desirable (they help to maintain the code in good health).

Let me know if you need somebody to merge this for you.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129156/new/

https://reviews.llvm.org/D129156