[flang-commits] [PATCH] D133554: [flang] Add *BSD support to Optimizer/CodeGen/Target.cpp

Mon Oct 3 13:43:55 PDT 2022

MaskRay added a comment.

In D133554#3794660 <https://reviews.llvm.org/D133554#3794660>, @rovka wrote:

> Hi, I have a couple of questions:
>
> - Are you actually testing on all these platforms? I don't think I've seen any BSD binaries for LLVM 15.
> - Do you plan to add any buildbots with flang on *BSD?
> - How different is the ABI from plain Linux? Will you need any changes in the handling of Complex / Character types (see the target-rewrite-* tests like this one <https://github.com/llvm/llvm-project/blob/main/flang/test/Fir/target-rewrite-complex.fir>) ?

The ELF operating systems have identical codegen behaviors since they follow the same ABI documents: System V Application Binary Interface + Processor Supplementary ABIs.
If some compatibility check is needed, it should be among Mach-O/Windows/ELF. But I don't think such a restriction is useful in codegen. Such check should be moved to Driver.
Sent D135100 <https://reviews.llvm.org/D135100>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133554/new/

https://reviews.llvm.org/D133554