[flang-commits] [PATCH] D126279: [Fortran] Set QUIET = .TRUE. in STOP statements

[Peter Klausler via Phabricator via flang-commits]

klausler added a comment.

In D126279#3536557 <https://reviews.llvm.org/D126279#3536557>, @rovka wrote:

> I can do that <https://reviews.llvm.org/D126360>, but I don't like that solution. My understanding is that these warnings are platform-dependent, and also the 'Fortran STOP' seems to be printed by default by flang. This means pretty much anyone running the test-suite with flang will have to set this environment variable, or else face a ton of failures. Why make the test-suite harder to run? I think one of the goals of the test-suite is to be independent from both the hardware and the compiler, and all the better if it's possible to achieve that without compiler-specific hacks. In this case, setting the STOP statement to QUIET makes sense to me because its output is not strictly defined by the standard and will vary with both hardware and compiler. The test-suite is not a good place to test warnings, error messages or other fuzzy output - that should go in flang's own tests.

FCVS is very old code; it antedates the recent `STOP QUIET` feature.  We run it because Fortran is short on publicly available test suites and because we want to be able to say that we pass this old famous suite.  I agree that it would be best if FCVS's official sources could be updated, but it's basically a museum piece now.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126279/new/

https://reviews.llvm.org/D126279