[flang-commits] [PATCH] D123331: Expand coverage of this_image semantics testing

[Katherine Rasmussen via Phabricator via flang-commits]

ktras added a comment.

The test is looking great, but I have recognized a couple more changes I would suggest. Please see the inline comments. I would also recommend adding a non-standard conforming call where a constant, either a constant variable or a literal constant, is being passed to the `dim` argument and where its value is out of bounds of the `corank` of the `coarray` argument.



================
Comment at: flang/test/Semantics/this_image02.f90:24
+  !___ standard-conforming statements with coarray argument present ___
+  n = this_image(co_array)
+  n = this_image(coarray=co_array)
----------------
When the `coarray` argument is present, but the `dim` argument is not present, the result will be an array of rank one, so this could be moved to the non-standard conforming section of the test and it could be replaced with a call where the result is assigned to an array.


================
Comment at: flang/test/Semantics/this_image02.f90:25
+  n = this_image(co_array)
+  n = this_image(coarray=co_array)
+
----------------
Similar to the comments on the line above, to keep this in the standards conforming section of your test, please replace the variable that the result of the call is being assigned to with an array.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123331/new/

https://reviews.llvm.org/D123331