[flang-commits] [flang] ea18987 - [flang][nfc] Fix driver method names overridden by the plugins

[Andrzej Warzynski via flang-commits]

Thanks for asking - that's already there: 
https://github.com/llvm/llvm-zorg/blob/ecf7ef3ad60ddb0066a100eb320ead58886578d3/buildbot/osuosl/master/config/builders.py#L1901 
:)

Sorry, I should've mentioned in the commit message that my original 
patch (https://reviews.llvm.org/D125007) broke that buildbot (i.e. 
`flang-aarch64-sharedlibs`). That's what happens when you submit patches 
on a Sunday :/

-Andrzej

On 16/05/2022 09:48, Diana Picus wrote:
> Is there an action item here to enable the examples on one of the buildbots? :)
>
> On Sun, 15 May 2022 at 19:58, Andrzej Warzynski via flang-commits
> <flang-commits at lists.llvm.org> wrote:
>>
>> Author: Andrzej Warzynski
>> Date: 2022-05-15T17:58:04Z
>> New Revision: ea18987094eff5a5835135da1f472d2e7bf6c68e
>>
>> URL: https://github.com/llvm/llvm-project/commit/ea18987094eff5a5835135da1f472d2e7bf6c68e
>> DIFF: https://github.com/llvm/llvm-project/commit/ea18987094eff5a5835135da1f472d2e7bf6c68e.diff
>>
>> LOG: [flang][nfc] Fix driver method names overridden by the plugins
>>
>> After the recent re-factoring of the driver code
>> (https://reviews.llvm.org/D125007), `ExecuteAction` was renamed as
>> `executeAction`. This patch updates the examples in Flang accordingly.
>>
>> If you set `FLANG_BUILD_EXAMPLES` to `On` when building Flang, then the
>> refactoring from D125007 would have caused build failures for you. This
>> patch fixes that.
>>
>> This is fairly straightforward and fixes buildbot failures, so I'm
>> sending this without a review.
>>
>> Added:
>>
>>
>> Modified:
>>      flang/examples/FlangOmpReport/FlangOmpReport.cpp
>>      flang/examples/PrintFlangFunctionNames/PrintFlangFunctionNames.cpp
>>
>> Removed:
>>
>>
>>
>> ################################################################################
>> diff  --git a/flang/examples/FlangOmpReport/FlangOmpReport.cpp b/flang/examples/FlangOmpReport/FlangOmpReport.cpp
>> index 229d6d1c120a7..9c1f304b9741e 100644
>> --- a/flang/examples/FlangOmpReport/FlangOmpReport.cpp
>> +++ b/flang/examples/FlangOmpReport/FlangOmpReport.cpp
>> @@ -49,7 +49,7 @@ template <> struct MappingTraits<LogRecord> {
>>   } // namespace llvm
>>
>>   class FlangOmpReport : public PluginParseTreeAction {
>> -  void ExecuteAction() override {
>> +  void executeAction() override {
>>       // Prepare the parse tree and the visitor
>>       Parsing &parsing = getParsing();
>>       OpenMPCounterVisitor visitor;
>>
>> diff  --git a/flang/examples/PrintFlangFunctionNames/PrintFlangFunctionNames.cpp b/flang/examples/PrintFlangFunctionNames/PrintFlangFunctionNames.cpp
>> index 90590bedb292b..4a84c3bd9fb99 100644
>> --- a/flang/examples/PrintFlangFunctionNames/PrintFlangFunctionNames.cpp
>> +++ b/flang/examples/PrintFlangFunctionNames/PrintFlangFunctionNames.cpp
>> @@ -65,7 +65,7 @@ class PrintFunctionNamesAction : public PluginParseTreeAction {
>>       bool isInSubprogram_{false};
>>     };
>>
>> -  void ExecuteAction() override {
>> +  void executeAction() override {
>>       ParseTreeVisitor visitor;
>>       Fortran::parser::Walk(getParsing().parseTree(), visitor);
>>
>>
>>
>>
>> _______________________________________________
>> flang-commits mailing list
>> flang-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/flang-commits