[flang-commits] [PATCH] D125672: [flang][Runtime] Use proper prototypes in Fortran_main. NFCI

Diana Picus via Phabricator via flang-commits flang-commits at lists.llvm.org
Mon May 16 02:08:34 PDT 2022


rovka created this revision.
rovka added reviewers: klausler, jeanPerier, awarzynski, kiranchandramohan.
rovka added a project: Flang.
Herald added a subscriber: jdoerfert.
Herald added a project: All.
rovka requested review of this revision.

This is compiled as C code, so it's a good idea to be explicit about the
prototype. Clang complains about this when -Wstrict-prototypes is used.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D125672

Files:
  flang/include/flang/Runtime/main.h
  flang/runtime/FortranMain/Fortran_main.c


Index: flang/runtime/FortranMain/Fortran_main.c
===================================================================
--- flang/runtime/FortranMain/Fortran_main.c
+++ flang/runtime/FortranMain/Fortran_main.c
@@ -10,7 +10,7 @@
 #include "flang/Runtime/stop.h"
 
 /* main entry into PROGRAM */
-void _QQmain();
+void _QQmain(void);
 
 /* C main stub */
 int main(int argc, const char *argv[], const char *envp[]) {
Index: flang/include/flang/Runtime/main.h
===================================================================
--- flang/include/flang/Runtime/main.h
+++ flang/include/flang/Runtime/main.h
@@ -14,7 +14,7 @@
 
 FORTRAN_EXTERN_C_BEGIN
 void RTNAME(ProgramStart)(int, const char *[], const char *[]);
-void RTNAME(ByteswapOption)(); // -byteswapio
+void RTNAME(ByteswapOption)(void); // -byteswapio
 FORTRAN_EXTERN_C_END
 
 #endif // FORTRAN_RUNTIME_MAIN_H_


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125672.429652.patch
Type: text/x-patch
Size: 865 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20220516/16baf278/attachment-0001.bin>


More information about the flang-commits mailing list