[flang-commits] [flang] ebe24a2 - [flang] Change "unsupported" messages in the runtime to "not yet implemented"

[Peter Steinfeld via flang-commits]

Author: Peter Steinfeld
Date: 2022-05-05T15:20:01-07:00
New Revision: ebe24a2a3116a5668c3fff27524d485e6956072e

URL: https://github.com/llvm/llvm-project/commit/ebe24a2a3116a5668c3fff27524d485e6956072e
DIFF: https://github.com/llvm/llvm-project/commit/ebe24a2a3116a5668c3fff27524d485e6956072e.diff

LOG: [flang] Change "unsupported" messages in the runtime to "not yet implemented"

If a programmer is able to compile and link a program that contains types that
are not yet supported by the runtime, it must be because they're not yet
implemented.

This change will make it easier to find unimplemented code in tests.

Differential Revision: https://reviews.llvm.org/D125046

Added: 
    

Modified: 
    flang/runtime/tools.h

Removed: 
    


################################################################################
diff  --git a/flang/runtime/tools.h b/flang/runtime/tools.h
index 5740eed5940a5..dd35917b58e9b 100644
--- a/flang/runtime/tools.h
+++ b/flang/runtime/tools.h
@@ -134,7 +134,7 @@ inline RESULT ApplyType(
       return FUNC<TypeCategory::Integer, 16>{}(std::forward<A>(x)...);
 #endif
     default:
-      terminator.Crash("unsupported INTEGER(KIND=%d)", kind);
+      terminator.Crash("not yet implemented: INTEGER(KIND=%d)", kind);
     }
   case TypeCategory::Real:
     switch (kind) {
@@ -156,7 +156,7 @@ inline RESULT ApplyType(
       return FUNC<TypeCategory::Real, 16>{}(std::forward<A>(x)...);
 #endif
     default:
-      terminator.Crash("unsupported REAL(KIND=%d)", kind);
+      terminator.Crash("not yet implemented: REAL(KIND=%d)", kind);
     }
   case TypeCategory::Complex:
     switch (kind) {
@@ -178,7 +178,7 @@ inline RESULT ApplyType(
       return FUNC<TypeCategory::Complex, 16>{}(std::forward<A>(x)...);
 #endif
     default:
-      terminator.Crash("unsupported COMPLEX(KIND=%d)", kind);
+      terminator.Crash("not yet implemented: COMPLEX(KIND=%d)", kind);
     }
   case TypeCategory::Character:
     switch (kind) {
@@ -189,7 +189,7 @@ inline RESULT ApplyType(
     case 4:
       return FUNC<TypeCategory::Character, 4>{}(std::forward<A>(x)...);
     default:
-      terminator.Crash("unsupported CHARACTER(KIND=%d)", kind);
+      terminator.Crash("not yet implemented: CHARACTER(KIND=%d)", kind);
     }
   case TypeCategory::Logical:
     switch (kind) {
@@ -202,10 +202,11 @@ inline RESULT ApplyType(
     case 8:
       return FUNC<TypeCategory::Logical, 8>{}(std::forward<A>(x)...);
     default:
-      terminator.Crash("unsupported LOGICAL(KIND=%d)", kind);
+      terminator.Crash("not yet implemented: LOGICAL(KIND=%d)", kind);
     }
   default:
-    terminator.Crash("unsupported type category(%d)", static_cast<int>(cat));
+    terminator.Crash(
+        "not yet implemented: type category(%d)", static_cast<int>(cat));
   }
 }
 
@@ -227,7 +228,7 @@ inline RESULT ApplyIntegerKind(int kind, Terminator &terminator, A &&...x) {
     return FUNC<16>{}(std::forward<A>(x)...);
 #endif
   default:
-    terminator.Crash("unsupported INTEGER(KIND=%d)", kind);
+    terminator.Crash("not yet implemented: INTEGER(KIND=%d)", kind);
   }
 }
 
@@ -253,7 +254,7 @@ inline RESULT ApplyFloatingPointKind(
     return FUNC<16>{}(std::forward<A>(x)...);
 #endif
   default:
-    terminator.Crash("unsupported REAL/COMPLEX(KIND=%d)", kind);
+    terminator.Crash("not yet implemented: REAL/COMPLEX(KIND=%d)", kind);
   }
 }
 
@@ -267,7 +268,7 @@ inline RESULT ApplyCharacterKind(int kind, Terminator &terminator, A &&...x) {
   case 4:
     return FUNC<4>{}(std::forward<A>(x)...);
   default:
-    terminator.Crash("unsupported CHARACTER(KIND=%d)", kind);
+    terminator.Crash("not yet implemented: CHARACTER(KIND=%d)", kind);
   }
 }
 
@@ -283,7 +284,7 @@ inline RESULT ApplyLogicalKind(int kind, Terminator &terminator, A &&...x) {
   case 8:
     return FUNC<8>{}(std::forward<A>(x)...);
   default:
-    terminator.Crash("unsupported LOGICAL(KIND=%d)", kind);
+    terminator.Crash("not yet implemented: LOGICAL(KIND=%d)", kind);
   }
 }