[flang-commits] [PATCH] D124846: [flang][driver] Support reading response files

[Diana Picus via Phabricator via flang-commits]

rovka added inline comments.


================
Comment at: flang/test/Driver/response-file.f90:4
+! RUN: echo "-DTEST" > %basename_t.rsp
+! RUN: %flang -E -cpp @%basename_t.rsp %s -o - | FileCheck %s
+! RUN: %flang_fc1 -E -cpp @%basename_t.rsp %s -o - | FileCheck %s
----------------
awarzynski wrote:
> What happens if you skip `@`? Perhaps test for that too.
We get a 'linker input unused' warning (same as clang). Not sure if that's really worth testing...


================
Comment at: flang/tools/flang-driver/driver.cpp:79
 
+  // Parse response files. We're defaulting to the GNU syntax, since we don't
+  // have a CL mode.
----------------
awarzynski wrote:
> Would it make sense to move this to a dedicated function? I imagine that this might grow in the future (especially when working on Windows). No strong opinion.
Can do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124846/new/

https://reviews.llvm.org/D124846