[flang-commits] [PATCH] D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline

Wed May 4 04:58:04 PDT 2022

awarzynski added a comment.

In D121171#3490631 <https://reviews.llvm.org/D121171#3490631>, @rovka wrote:

> Ping?

Sorry for the delay and thanks for driving this!

The current approach sounds like a good compromise to me. It does mean that we will need to use `-external-name-interop` when using `flang-new` alongside `tco` in tests. If that becomes too painful, we can always introduce a dedicated LIT variable or revisit this altogether.

A test using `flang-new` that exercises `-external-name-interop` would be nice :) Otherwise, LGTM!

================
Comment at: flang/test/Driver/pass-pipeline.f90:3
+
+! FIXME: Also check LLVM passes
+! RUN: %flang_fc1 -S -mmlir --mlir-pass-statistics -mmlir --mlir-pass-statistics-display=pipeline %s -o - 2>&1 | FileCheck %s
----------------
[nit] Why not rename the file as `mlir-pass-pipeline.f90` and remove this `FIXME`? We definitely should test the LLVM pipeline too, but for that we will need a different command line flag. 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121171/new/

https://reviews.llvm.org/D121171