[flang-commits] [PATCH] D123331: Expand coverage of this_image semantics testing

[Katherine Rasmussen via Phabricator via flang-commits]

ktras requested changes to this revision.
ktras added a comment.
This revision now requires changes to proceed.

I have only one small suggestion, please see the suggested code edit.



================
Comment at: flang/test/Semantics/this_image02.f90:83
+  !ERROR: missing mandatory 'dim=' argument
+  n = this_image(league)
+
----------------
Since `team` is an optional argument, I would recommend using the keyword argument here to explicitly test whether the `team` argument is being restricted to a scalar of team_type or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123331/new/

https://reviews.llvm.org/D123331