[flang-commits] [PATCH] D128009: [flang] Add semantics test for image_status and add a check
Katherine Rasmussen via Phabricator via flang-commits
flang-commits at lists.llvm.org
Wed Jun 29 15:31:47 PDT 2022
ktras marked an inline comment as done.
ktras added inline comments.
================
Comment at: flang/lib/Evaluate/intrinsics.cpp:2350
+ context.messages().Say(arg->sourceLocation(),
+ "'image=' argument for intrinsic '%s' must be a positive value"_err_en_US,
+ name);
----------------
klausler wrote:
> Here and in the other two messages: you have the bad value in hand, why not include it in the message?
It didn't cross my mind to, but I can definitely try to come up with an error message that includes the bad value. Thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128009/new/
https://reviews.llvm.org/D128009
More information about the flang-commits
mailing list