[flang-commits] [PATCH] D128261: [Fortran] Relax tolerance for FCVS tests

Wed Jun 29 02:59:31 PDT 2022

awarzynski added a comment.

This change makes sense to me, thanks! Could you also update the summary? There's quite a lot of detail there, which can be skipped. Also, could you highlight that you are updating the relative tolerance here?

================
Comment at: Fortran/UnitTests/fcvs21_f95/CMakeLists.txt:43
 set(FP_IGNOREWHITESPACE ON)
+set(FP_TOLERANCE 1.0e-7) # test 905
 llvm_singlesource()
----------------
Could you add a comment saying that this is the relative tolerance? I think that this is key here.

Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128261/new/

https://reviews.llvm.org/D128261