[flang-commits] [PATCH] D127805: Bitwise comparison intrinsics

[vdonaldson via Phabricator via flang-commits]

vdonaldson added inline comments.


================
Comment at: flang/lib/Lower/IntrinsicCall.cpp:467-470
+  mlir::Value genBge(mlir::Type resultType, llvm::ArrayRef<mlir::Value> args);
+  mlir::Value genBgt(mlir::Type resultType, llvm::ArrayRef<mlir::Value> args);
+  mlir::Value genBle(mlir::Type resultType, llvm::ArrayRef<mlir::Value> args);
+  mlir::Value genBlt(mlir::Type resultType, llvm::ArrayRef<mlir::Value> args);
----------------
These intermediate declarations can be skipped in favor of direct calls to genBitwiseCompare, the definition of which is then is no longer a helper function and can be moved down in the code.  Compare the code for lge, lgt, lle, llt.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127805/new/

https://reviews.llvm.org/D127805