[flang-commits] [PATCH] D128009: [flang] Add semantics test for image_status and add a check

[Peter Klausler via Phabricator via flang-commits]

klausler added a comment.

In D128009#3604129 <https://reviews.llvm.org/D128009#3604129>, @jeanPerier wrote:

> Thanks, it is great to be able to provide more compile time feedback. I think `KindCode` is not the right place to encode and complain about illegal argument values when they can be known and checked at compile time.
>
> @klausler, would adding a new field with that purpose to `IntrinsicDummyArgument` make sense to you ?

No.  That struct is too complicated already.  A custom check would be better, as is done for several other cases.  Also, lowering will need to worry about the SIZE= argument to ISHFTC being an absent incoming dummy argument.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128009/new/

https://reviews.llvm.org/D128009