[flang-commits] [PATCH] D126291: [flang][Driver] Update link job on windows

[Andrzej Warzynski via Phabricator via flang-commits]

awarzynski added inline comments.


================
Comment at: flang/test/Driver/linker-flags.f90:28
+
+! GNU-WITHOUTLM-LABEL:  "{{.*}}ld" 
+! GNU-WITHOUTLM-SAME: "[[object_file]]"
----------------
I think that GNU in this case might be a bit misleading. These linker invocations are defined in almost completely independent toolchains: [[ https://github.com/llvm/llvm-project/blob/b9a7dea9171416a998e4fa3333fb9f76baa167b8/clang/lib/Driver/ToolChains/Darwin.h#L33-L47 | MachOTool ]], [[ https://github.com/llvm/llvm-project/blob/b9a7dea9171416a998e4fa3333fb9f76baa167b8/clang/lib/Driver/ToolChains/Gnu.h#L40-L51 | gnutools ]].

I't be inclined to try this instead:
```
! RUN: %flang -### -flang-experimental-exec -target ppc64le-linux-gnu %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,GNU
! RUN: %flang -### -flang-experimental-exec -target aarch64-apple-darwin %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,DARWIN
! RUN: %flang -### -flang-experimental-exec -target x86_64-windows-gnu %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,MINGW
! RUN: %flang -### -flang-experimental-exec -target aarch64-windows-msvc %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,MSVC
```

This will lead to more duplication, but would clarify things a bit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126291/new/

https://reviews.llvm.org/D126291