[flang-commits] [PATCH] D126291: [flang][Driver] Update link job on windows

Mon Jun 13 04:15:30 PDT 2022

rovka added a comment.

I'm guessing the Windows precommit is failing because --ld-path is ignored on Windows, even if we use a Linux target? I have a fix that works on my Windows machine, coming right up.

================
Comment at: flang/test/Driver/linker-flags.f90:28
+! GNU-SAME: -lFortranDecimal
+! WITHLM-SAME: -lm
+
----------------
awarzynski wrote:
> Does `-SAME` makese sense here? As in, this makes sense to me:
> ```
> ! GNU: -lFortranDecimal
> ! GNU-SAME: -lm
> ```
> and this:
> ```
> ! WITHLM: -lFortranDecimal
> ! WITHLM-SAME: -lm
> ```
> but for `! WITHLM-SAME: -lm` there's no [[ https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-same-directive | previous match ]], is there?
It doesn't say that the previous match has to be with the same prefix, and it seems to work :)
But since it looks funny to at least one person, I'll update it to use the same prefix.

================
Comment at: flang/test/Driver/linker-flags.f90:33-34
+! MSVC-LABEL: link.exe
+! MSVC-NOT: libcmt
+! MSVC-NOT: oldnames
+! MSVC-SAME: Fortran_main.lib
----------------
awarzynski wrote:
> Is it worth adding a comment to explain why to single these out?
I guess it won't hurt 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126291/new/

https://reviews.llvm.org/D126291