[flang-commits] [PATCH] D126291: [flang][Driver] Update link job on windows

[Diana Picus via Phabricator via flang-commits]

rovka added a comment.

In D126291#3572796 <https://reviews.llvm.org/D126291#3572796>, @mmuetzel wrote:

> In D126291#3572777 <https://reviews.llvm.org/D126291#3572777>, @rovka wrote:
>
>> Moved the check for `-flang-experimental-exec` into addFortranRuntimeLibraryPath, so it affects all the toolchains. @awarzynski does this look like a good idea?
>
> If moving that check to inside that function is ok, should the same check be added to `addFortranRuntimeLibs`, too?
> Edit: And also retain that condition for any flags that are added in the respective part of the toolchain files that don't use any of these two functions?

I don't think we need to add it to the other function since we'll get an error anyway if the linker can't find the libraries. In any case, the right way to handle this is probably to error out in the driver before trying to compose a link job when `-flang-experimental-exec` is not specified, rather than rely on a specific linker error. But that should probably be a different patch. @awarzynski wdyt?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126291/new/

https://reviews.llvm.org/D126291