[flang-commits] [PATCH] D127316: [flang][runtime] Remove dependency on C++ <mutex> on Windows

[Markus Mützel via Phabricator via flang-commits]

mmuetzel added a comment.

In D127316#3572625 <https://reviews.llvm.org/D127316#3572625>, @rovka wrote:

> Hi @mmuetzel,
>
> Thanks for submitting this! I think the NOMINMAX trick should fix the issues I was seeing on Windows on Arm, but I still need to test to be sure (it's slow...). Do you have commit access or should I commit on your behalf?

I don't think I have commit access (unless there is some phabricator magic going on behind the curtains that I'm not aware of). I'd be happy if you could push this to the repo (if/when your tests have been successful).

> One small Phabricator nitpick: it's nice to upload patches with context <https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface:~:text=one%20of%20the%20following%20commands> (you don't have to do that for this patch, I was just mentioning it for the future).

Thanks for the hint. I'll try to remember that in the future.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127316/new/

https://reviews.llvm.org/D127316