[flang-commits] [PATCH] D114134: [flang] Add co_sum to the list of intrinsics and update test

[Katherine Rasmussen via Phabricator via flang-commits]

ktras planned changes to this revision.
ktras added inline comments.


================
Comment at: flang/lib/Evaluate/intrinsics.cpp:1639
+  // added to the list of intrinsic subroutines
+  if (std::strcmp(name, "move_alloc") == 0 ||
+      std::strcmp(name, "co_sum") == 0) {
----------------
jeanPerier wrote:
> I think this custom check might better belong in ApplySpecificChecks that does custom checks that do not fit in the automated checks.
Thanks for pointing that function out. I agree that moving this check to `ApplySpecificChecks()` seems like an appropriate change. I will work on doing that and updating the diff. Thanks for the feedback!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114134/new/

https://reviews.llvm.org/D114134