[flang-commits] [PATCH] D126291: [flang][Driver] Update link job on windows

[Andrzej Warzynski via Phabricator via flang-commits]

awarzynski added a comment.



In D126291#3562542 <https://reviews.llvm.org/D126291#3562542>, @mstorsjo wrote:

> In D126291#3562471 <https://reviews.llvm.org/D126291#3562471>, @mmuetzel wrote:
>
>> Found why I thought building on Windows wasn't supported:
>> https://github.com/llvm/llvm-project/blob/main/flang/README.md?plain=1#L153
>>
>>> The code does not compile with Windows and a compiler that does not have support for C++17.
>>
>> But re-reading this again, I might have mis-read the "and" for an "or"...
>
> Don't read too much into it - it used to be the case that flang wasn't tested/supported at all on Windows, but at this point I think this comment just is outdated/leftovr.

That's correct - that note is out-of-date and I have just deleted it <https://github.com/llvm/llvm-project/commit/e4f47c8e058b708d3fc43c15538154ec0cf46bc2>. There are also old release notes <https://releases.llvm.org/14.0.0/tools/flang/docs/ReleaseNotes.html> that are also incorrect :(

In D126291#3561854 <https://reviews.llvm.org/D126291#3561854>, @Meinersbur wrote:

> The bot just compiles flang and runs the unit-test, none of which actually try to compile, link & run a Fortan program.

My point was that the level of support on Windows is in general on a par with other platforms. There are small differences (there always will be), but patches like this one aim to fix that. In particular, the level of testing coverage is very similar.

> Until recently the flang driver would not compile itself, but delegate it to gfortran anyway.

The "delegation" is done by the flang-to-external-fc <https://github.com/llvm/llvm-project/blob/main/flang/docs/FlangDriver.md#the-flang-to-external-fc-script> bash wrapper script for the driver rather than the driver itself (until recently, this script used to be called `flang`).

In D126291#3561854 <https://reviews.llvm.org/D126291#3561854>, @Meinersbur wrote:

> I tested the updated patch again it is failing:

The test that is failing for you is not intended for Windows. @rovka , I think that that you meant `! UNSUPPORTED: system-windows` rather than `! UNSUPPORTED: windows-msvc`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126291/new/

https://reviews.llvm.org/D126291