[flang-commits] [PATCH] D127021: [flang] Don't discard lower bounds of implicit-shape named constants
Peter Klausler via Phabricator via flang-commits
flang-commits at lists.llvm.org
Fri Jun 3 15:54:53 PDT 2022
klausler created this revision.
klausler added a reviewer: vdonaldson.
klausler added a project: Flang.
Herald added a subscriber: jdoerfert.
Herald added a project: All.
klausler requested review of this revision.
The compiler preserves lower bounds of explicit-shape named constant arrays, but
failed to also do so for implicit-shape named constants. Fix.
https://reviews.llvm.org/D127021
Files:
flang/lib/Evaluate/check-expression.cpp
Index: flang/lib/Evaluate/check-expression.cpp
===================================================================
--- flang/lib/Evaluate/check-expression.cpp
+++ flang/lib/Evaluate/check-expression.cpp
@@ -418,7 +418,10 @@
int symRank{GetRank(symTS->shape())};
if (IsImpliedShape(symbol)) {
if (folded.Rank() == symRank) {
- return {std::move(folded)};
+ return ArrayConstantBoundChanger{
+ std::move(*AsConstantExtents(
+ context, GetRawLowerBounds(context, NamedEntity{symbol})))}
+ .ChangeLbounds(std::move(folded));
} else {
context.messages().Say(
"Implied-shape parameter '%s' has rank %d but its initializer has rank %d"_err_en_US,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127021.434179.patch
Type: text/x-patch
Size: 781 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20220603/0e6ee623/attachment.bin>
More information about the flang-commits
mailing list