[flang-commits] [PATCH] D117904: [flang] Fix repeated "DT" editing

Peter Klausler via Phabricator via flang-commits flang-commits at lists.llvm.org
Fri Jan 21 09:25:12 PST 2022


klausler created this revision.
klausler added a reviewer: vdonaldson.
klausler added a project: Flang.
Herald added a subscriber: jdoerfert.
klausler requested review of this revision.

User-defined derived type editing in formatted I/O wasn't
working with repeat counts; e.g., "2DT(10)".  The solution required
some code to be moved from GetNextDataEdit() to CueUpNextDataEdit() so
that a stack entry for a nonparenthesized repeated data edit
descriptor would work correctly -- all other data edit descriptors
are capable of dealing with repetition in their callees, so the bug
hadn't been exposed before.

Debugging this problem led to some improvements in error messages
for bad format strings, and those changes have been retained; also,
a dead member function was discovered and expunged.


https://reviews.llvm.org/D117904

Files:
  flang/runtime/descriptor-io.cpp
  flang/runtime/format-implementation.h
  flang/runtime/format.h
  flang/runtime/io-stmt.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117904.402017.patch
Type: text/x-patch
Size: 10911 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20220121/860487a1/attachment-0001.bin>


More information about the flang-commits mailing list