[flang-commits] [PATCH] D116933: [flang] Do not lose call in shape inquiry on function reference

Peter Klausler via Phabricator via flang-commits flang-commits at lists.llvm.org
Mon Jan 10 08:56:38 PST 2022


klausler accepted this revision.
klausler added a comment.
This revision is now accepted and ready to land.

LGTM and thanks!



================
Comment at: flang/include/flang/Evaluate/shape.h:248
 
+// Get shape that does not depends on callee scope symbols if the expression
+// contains calls. Return std::nullopt if it is not possible to build such shape
----------------
Comment would be better as "GetShape() variant that does not..."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116933/new/

https://reviews.llvm.org/D116933



More information about the flang-commits mailing list