[flang-commits] [PATCH] D120097: [flang] Add semantics test for the sync memory statement

[Katherine Rasmussen via Phabricator via flang-commits]

ktras accepted this revision.
ktras added a comment.
This revision is now accepted and ready to land.

LGTM. The only note is that, similar to D114181 <https://reviews.llvm.org/D114181>, this test should pass if you take away the XFAIL directive, but doesn't because flang doesn't currently enforce some of the syntax and constraints stated in the standard:

- `stat-variable` must an integer scalar (both a logical and an integer array do not create errors currently)
- ``stat-variable`scalar-default-char-variable
- C1171 - that no specifier shall appear more than once in a given `sync-stat-list`
- C1172 - that a `stat-variable` or `errmsg-variable` in a `sync-stat` shall not be a `coindexed object`

It seems appropriate to open up an issue on the github repository pointing this out after this commit is pushed, and referencing this test in the issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120097/new/

https://reviews.llvm.org/D120097