[flang-commits] [PATCH] D118933: Add semantics unit test for SYNC IMAGES statement

[Katherine Rasmussen via Phabricator via flang-commits]

ktras added a comment.

LGTM. The only note is that this test, like the `sync all` test in differential `D114181`, should pass if you take away the XFAIL directive, but doesn't because flang doesn't currently enforce the following constraints stated in the standard: `C1171` - that no specifier shall appear more than once in a given `sync-stat-list`, and `C1172` - that a `stat-variable` or `errmsg-variable` in a `sync-stat` shall not be a `coindexed object`, `C1173` - that an `image-set` that is an `int-expr` shall be scalar or of rank one, and `C1174` that the value of `image-set` shall not depend on the value of `stat-variable` or `errmsg-variable`. It seems appropriate to open up an issue on the github repository pointing this out after this commit is pushed, and referencing this test in the issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118933/new/

https://reviews.llvm.org/D118933