[flang-commits] [PATCH] D132519: [flang] Write semantics test for atomic_fetch_or

[Damian Rouson via Phabricator via flang-commits]

rouson added inline comments.


================
Comment at: flang/test/Semantics/atomic7.f90:21
+  call atomic_fetch_or(scalar_coarray, val, old_val, status)
+  call atomic_fetch_or(scalar_coarray, val, old_val, atomic_status)
+  call atomic_fetch_or(scalar_coarray[1], val, old_val, status)
----------------
There's probably not a specific reason to test any stat argument kind other than the default integer kind.


================
Comment at: flang/test/Semantics/atomic7.f90:70
+
+  call atomic_fetch_or(scalar_coarray, val, old_val, coindexed_status)
+
----------------
coindexed_status is not coindexed


================
Comment at: flang/test/Semantics/atomic7.f90:127
+  !ERROR: keyword argument to intrinsic 'atomic_fetch_or' was supplied positionally by an earlier actual argument
+  call atomic_fetch_or(scalar_coarray, val, old_val, stat=repeated_status)
+
----------------
This line appears to be standard-conforming.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132519/new/

https://reviews.llvm.org/D132519