[flang-commits] [PATCH] D132594: [flang] Fix msvc 17.3 build.

Peter Klausler via Phabricator via flang-commits flang-commits at lists.llvm.org
Wed Aug 24 12:44:48 PDT 2022


klausler accepted this revision.
klausler added inline comments.
This revision is now accepted and ready to land.


================
Comment at: flang/lib/Evaluate/fold-integer.cpp:804
                 }));
           },
           sn->u);
----------------
Please add a comment that this unexpected usage is meant to work around a particular compiler problem, as has been done at other code sites where workarounds have been needed.  It helps explain why the code is more general than necessary, and can also be a valuable assist to programmers confronted with similar C++ compiler bugs in newer code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132594/new/

https://reviews.llvm.org/D132594



More information about the flang-commits mailing list