[flang-commits] [PATCH] D132167: [flang] Support for character array formats

[Kiran Chandramohan via Phabricator via flang-commits]

kiranchandramohan added a comment.

@klausler SNAP fails with this patch. https://github.com/banach-space/llvm-project/runs/7910556327?check_suite_focus=true

  /home/runner/work/llvm-project/llvm-project/build//bin/flang-new  -c time.f90
  error: loc("./time.f90":19:7): 'llvm.call' op incorrect number of operands (5) for callee (expecting: 6)
  error: Lowering to LLVM IR failed
  Incorrect number of arguments passed to called function!
    %14 = call ptr @_FortranAioBeginExternalFormattedOutput(ptr @_QQcl.473dced66a7e38e9ed6cb48a04ca778d, i64 42, i32 11, ptr @_QQcl.2E2F74696D652E66393000, i32 19), !dbg !15

Reproducer from SNAP

    SUBROUTINE time_summ
    CHARACTER(LEN=1) :: star='*'
    INTEGER :: i
    WRITE(*, 401) ( star, i = 1, 80 )
  401 FORMAT( 10X, 'keyword Timing Summary', /, 80A, / )
    END SUBROUTINE

I see that you already mention that some work is needed in lowering. Is someone working on this part? Shall we revert this patch until then? We can have a look if no one is working on this.

  Some work needs to be done in lowering to pass a character array
  descriptor to the I/O runtime API when present


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132167/new/

https://reviews.llvm.org/D132167