[flang-commits] [flang] 053498c - [Flang] Mark 128 float MODULO intrinsic calls as "TODO"

[Peter Steinfeld via flang-commits]

Author: Peter Steinfeld
Date: 2022-08-18T06:24:07-07:00
New Revision: 053498ccd3d9a1493df081f8ae2504d29911d4cd

URL: https://github.com/llvm/llvm-project/commit/053498ccd3d9a1493df081f8ae2504d29911d4cd
DIFF: https://github.com/llvm/llvm-project/commit/053498ccd3d9a1493df081f8ae2504d29911d4cd.diff

LOG: [Flang] Mark 128 float MODULO intrinsic calls as "TODO"

The code generated for this version of the intrinsic is broken.  I'm
marking it as a "TODO" for now so that people don't get unannounce bad
results.

Differential Revision: https://reviews.llvm.org/D132082

Added: 
    

Modified: 
    flang/lib/Lower/IntrinsicCall.cpp

Removed: 
    


################################################################################
diff  --git a/flang/lib/Lower/IntrinsicCall.cpp b/flang/lib/Lower/IntrinsicCall.cpp
index 5804bb1df066b..3e9d029a989d7 100644
--- a/flang/lib/Lower/IntrinsicCall.cpp
+++ b/flang/lib/Lower/IntrinsicCall.cpp
@@ -3486,6 +3486,9 @@ mlir::Value IntrinsicLibrary::genModulo(mlir::Type resultType,
                                                  remainder);
   }
   // Real case
+  if (resultType == mlir::FloatType::getF128(builder.getContext()))
+
+    TODO(loc, "intrinsic: MODULO for floating point of KIND=16");
   auto remainder = builder.create<mlir::arith::RemFOp>(loc, args[0], args[1]);
   mlir::Value zero = builder.createRealZeroConstant(loc, remainder.getType());
   auto remainderIsNotZero = builder.create<mlir::arith::CmpFOp>(