[flang-commits] [PATCH] D131054: [flang] Add Solaris/x86 support to Optimizer/CodeGen/Target.cpp

Wed Aug 17 02:51:45 PDT 2022

ro added a comment.

In D131054#3715140 <https://reviews.llvm.org/D131054#3715140>, @rovka wrote:

> 

> Are you planning to enable flang on a Solaris buildbot?

Not yet: I've been struggling to get the Solaris buildbots (both sparcv9 and amd64) reliably green for a long time.  Right now I'm almost there, but adding `flang`/`mlir` to the mix would be a considerable throwback:

With this patch applied, there are two remaining `FAILs` on Solaris/amd64:

  Failed Tests (2):
    MLIR :: Dialect/Math/canonicalize.mlir
    flang-OldUnit :: Evaluate/folding.test

However, Solaris/sparcv9 is way worse: it needs the SPARC equivalent of this patch (still WIP), D131151 <https://reviews.llvm.org/D131151> which is still unreviewed, and still has quite a number of `FAIL`s on top of that.

Until those are resolved, enabling `flang` in the buildbots would be a disservice, I believe, although it would certainy help to catch issues early rather than only discovering them during the release cycle.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131054/new/

https://reviews.llvm.org/D131054