[flang-commits] [PATCH] D131754: [Fortran] Re-enable FCVS FM905 & FM907

Diana Picus via Phabricator via flang-commits flang-commits at lists.llvm.org
Fri Aug 12 02:23:34 PDT 2022


rovka created this revision.
rovka added reviewers: Meinersbur, sscalpone, klausler, awarzynski.
rovka added a project: Flang.
Herald added subscribers: jdoerfert, mgorny.
Herald added a project: All.
rovka requested review of this revision.
Herald added a project: LLVM.

FM905 and FM907 have been disabled because they use list-directed
output, which gives the compiler some freedom regarding the exact format
and precision of the output. Our reference output had been obtained with
gfortran, and flang's output did not match.

This patch re-enables the tests, but switches the reference outputs to
match what flang produces. By default, we will check the output exactly.
However, the patch also introduces a new CMake variable,
FCVS_ALLOW_FLEXIBLE_OUTPUT, which can be set when running the
test-suite with other compilers (or even with other flags or environment
variables) and which will check the output more loosely. In this patch,
this only affect whether or not we ignore whitespace differences in the
output.

Note that this patch is not enough for the test-suite to pass with
gfortran, even when FCVS_ALLOW_FLEXIBLE_OUTPUT is enabled. Future
patches will try to fix that on a best-effort basis. Other fixes may be
required for other compilers or other compiler options.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131754

Files:
  Fortran/UnitTests/fcvs21_f95/CMakeLists.txt
  Fortran/UnitTests/fcvs21_f95/FM905.reference_output
  Fortran/UnitTests/fcvs21_f95/FM907.reference_output

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131754.452112.patch
Type: text/x-patch
Size: 5056 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20220812/db56e3ff/attachment-0001.bin>


More information about the flang-commits mailing list