[flang-commits] [PATCH] D130590: Fix Issue #56706 (maskl(0), maskr(0) return -1 instead of 0)

Valentin Clement via Phabricator via flang-commits flang-commits at lists.llvm.org
Mon Aug 8 11:42:49 PDT 2022


clementval added a comment.

In D130590#3707536 <https://reviews.llvm.org/D130590#3707536>, @tarunprabhu wrote:

> Noted. In my defense, there was a LGTM from @jeanPerier.
>
> In D130590#3682021 <https://reviews.llvm.org/D130590#3682021>, @jeanPerier wrote:
>
>> I agree with clementval's comment about the commit title (should also have [flang]), otherwise LGTM, thanks for fixing the bug !
>
> But I'll wait for a formal acceptance so there's no confusion.

My bad I did not notice it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130590/new/

https://reviews.llvm.org/D130590



More information about the flang-commits mailing list