[flang-commits] [PATCH] D123904: [flang] Remove obsolete error check

[Peter Klausler via Phabricator via flang-commits]

klausler created this revision.
klausler added a reviewer: vdonaldson.
klausler added a project: Flang.
Herald added a subscriber: jdoerfert.
Herald added a project: All.
klausler requested review of this revision.

A check in intrinsic procedure call analysis is no longer needed
after some recent work in name resolution and is now emitting false
error messages; remove.


https://reviews.llvm.org/D123904

Files:
  flang/lib/Evaluate/intrinsics.cpp


Index: flang/lib/Evaluate/intrinsics.cpp
===================================================================
--- flang/lib/Evaluate/intrinsics.cpp
+++ flang/lib/Evaluate/intrinsics.cpp
@@ -2409,11 +2409,6 @@
         return specificCall;
       }
     }
-    if (IsIntrinsicFunction(call.name)) {
-      context.messages().Say(
-          "Cannot use intrinsic function '%s' as a subroutine"_err_en_US,
-          call.name);
-    }
     return std::nullopt; // TODO
   }
 
@@ -2504,13 +2499,6 @@
     }
   }
 
-  if (specificBuffer.empty() && genericBuffer.empty() &&
-      IsIntrinsicSubroutine(call.name)) {
-    context.messages().Say(
-        "Cannot use intrinsic subroutine '%s' as a function"_err_en_US,
-        call.name);
-  }
-
   // No match; report the right errors, if any
   if (finalBuffer) {
     if (specificBuffer.empty()) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123904.423267.patch
Type: text/x-patch
Size: 847 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20220416/313fb250/attachment.bin>