[flang-commits] [PATCH] D123722: [flang] Allow modification of construct entities

[Peter Klausler via Phabricator via flang-commits]

klausler created this revision.
klausler added a reviewer: jeanPerier.
klausler added a project: Flang.
Herald added a subscriber: jdoerfert.
Herald added a project: All.
klausler requested review of this revision.

Construct entities from ASSOCIATE, SELECT TYPE, and SELECT RANK
are modifiable if the are associated with modifiable variables
without vector subscripts.  Update WhyNotModifiable() to accept
construct entities that are appropriate.

A need for more general error reporting from one overload of
WhyNotModifiable() caused its result type to change to
std::optional<parser::Message> instead of ::MessageFixedText,
and this change had some consequences that rippled through
call sites.

Some test results that didn't allow for modifiable construct
entities needed to be updated.


https://reviews.llvm.org/D123722

Files:
  flang/include/flang/Semantics/tools.h
  flang/lib/Semantics/check-omp-structure.cpp
  flang/lib/Semantics/resolve-names.cpp
  flang/lib/Semantics/tools.cpp
  flang/test/Semantics/modifiable01.f90
  flang/test/Semantics/resolve57.f90
  flang/test/Semantics/selecttype03.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123722.422623.patch
Type: text/x-patch
Size: 11144 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20220413/fbb918f2/attachment-0001.bin>