[flang-commits] [PATCH] D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline

[Andrzej Warzynski via Phabricator via flang-commits]

awarzynski added a comment.

Note that without this change, "flang/test/Lower/common-block.f90" can be run with both `bbc`/`tco` and `flang-new`. This change removes this possibility. We pledged to retire bbc/tco in favour of `flang-new` and this change is a step in the opposite direction (at least in it's current format) . I think that we should maintain the interoperability of tests using `bbc`/`tco` and `flang-new`.

> @awarzynski does flang-new have something that can forward options to MLIR? (I'm thinking of something like -mllvm)

I've recently added `-mllvm`, but I've not had the chance to look at `-mmlir`. To me, it would make sense to add it first and to make sure that "basic-program.fir" works with both `tco` and `flang-new`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121171/new/

https://reviews.llvm.org/D121171