[flang-commits] [PATCH] D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline

[Eric Schweitz via Phabricator via flang-commits]

schweitz added inline comments.


================
Comment at: flang/test/Lower/Intrinsics/abs.f90:6
 
-! CHECK-LABEL: func @_QPabs_testi
+! CHECK-LABEL: func @{{.*}}abs_testi{{.*}}(
 ! CHECK-SAME: %[[VAL_0:.*]]: !fir.ref<i32>{{.*}}, %[[VAL_1:.*]]: !fir.ref<i32>
----------------
Thanks @rovka for moving the pass to the default code gen passes. That's great.

Again, this CHECKing isn't going to work for Windows interoperability since the mangling of Fortran procedure names is different there. (Yes, even Fortran 77.) To future-proof this, we should allow bbc and flang-new to use different check lines rather than CHECKs that try to hit the intersection. I don't think it will be at all harmful to CHECK both the internal uniqued names (via bbc) and whatever exotic compatibility modes (via flang-new) come down the pike in the future. In fact, that seems quite desirable. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121171/new/

https://reviews.llvm.org/D121171