[flang-commits] [flang] 7362cc5 - [fir][NFC] Rename lenParams to typeparams in builders

Valentin Clement via flang-commits flang-commits at lists.llvm.org
Thu Sep 30 08:57:21 PDT 2021


Author: Eric Schweitz
Date: 2021-09-30T17:56:32+02:00
New Revision: 7362cc5ef50b5ebcbb11380ab13a179902c7b8be

URL: https://github.com/llvm/llvm-project/commit/7362cc5ef50b5ebcbb11380ab13a179902c7b8be
DIFF: https://github.com/llvm/llvm-project/commit/7362cc5ef50b5ebcbb11380ab13a179902c7b8be.diff

LOG: [fir][NFC] Rename lenParams to typeparams in builders

Fine tuning after couple of upstreamed patches.
Rename the lenParams varaiables in buidlers to typeparams.

This patch is part of the upstreaming effort from fir-dev branch.

Reviewed By: kiranchandramohan

Differential Revision: https://reviews.llvm.org/D110821

Co-authored-by: Valentin Clement <clementval at gmail.com>

Added: 
    

Modified: 
    flang/include/flang/Optimizer/Dialect/FIROps.td

Removed: 
    


################################################################################
diff  --git a/flang/include/flang/Optimizer/Dialect/FIROps.td b/flang/include/flang/Optimizer/Dialect/FIROps.td
index 217f1490047e..df4451b1bf43 100644
--- a/flang/include/flang/Optimizer/Dialect/FIROps.td
+++ b/flang/include/flang/Optimizer/Dialect/FIROps.td
@@ -854,9 +854,9 @@ def fir_EmboxOp : fir_Op<"embox", [NoSideEffect, AttrSizedOperandSegments]> {
     OpBuilder<(ins "llvm::ArrayRef<mlir::Type>":$resultTypes,
       "mlir::Value":$memref, CArg<"mlir::Value", "{}">:$shape,
       CArg<"mlir::Value", "{}">:$slice,
-      CArg<"mlir::ValueRange", "{}">:$lenParams),
+      CArg<"mlir::ValueRange", "{}">:$typeparams),
     [{ return build($_builder, $_state, resultTypes, memref, shape, slice,
-                    lenParams, mlir::AffineMapAttr{}); }]>
+                    typeparams, mlir::AffineMapAttr{}); }]>
   ];
 
   let assemblyFormat = [{
@@ -864,7 +864,7 @@ def fir_EmboxOp : fir_Op<"embox", [NoSideEffect, AttrSizedOperandSegments]> {
       (`map` $accessMap^)? attr-dict `:` functional-type(operands, results)
   }];
 
-  let verifier = [{ return ::verify(*this); }];
+  let verifier = "return ::verify(*this);";
 
   let extraClassDeclaration = [{
     mlir::Value getShape() { return shape(); }


        


More information about the flang-commits mailing list