[flang-commits] [PATCH] D109108: [flang] Use CMake to determine endianness.

[Andrzej Warzynski via Phabricator via flang-commits]

awarzynski added a comment.

In D109108#3028006 <https://reviews.llvm.org/D109108#3028006>, @AlexisPerry wrote:

> In D109108#3027357 <https://reviews.llvm.org/D109108#3027357>, @sscalpone wrote:
>
>> Time to upgrade to C++20?
>> https://en.cppreference.com/w/cpp/types/endian
>
> I would be loathe to adopt a newer C++ standard at the moment.  Didn't the larger LLVM community initially object to Flang's usage of C++17 because the rest of the codebase only used C++11?  I don't remember hearing that they have updated standards yet, and I wouldn't want to create a bigger stumbling block for integration with the larger community.

I agree.

While LLVM has since  switched to C++14 <https://github.com/llvm/llvm-project/blob/main/llvm/CMakeLists.txt#L48>, we should wait for the rest of LLVM to switch to C++17 before considering C++20.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109108/new/

https://reviews.llvm.org/D109108