[flang-commits] [PATCH] D110356: [flang] Make builtin types more easily accessible; use them

[Peter Klausler via Phabricator via flang-commits]

klausler marked an inline comment as done.
klausler added inline comments.


================
Comment at: flang/tools/f18/CMakeLists.txt:34
     COMMAND flang-new -fc1 -fsyntax-only -module-dir ${FLANG_INTRINSIC_MODULES_DIR}
-      ${FLANG_SOURCE_DIR}/module/${filename}.f90
+      -J ${FLANG_INTRINSIC_MODULES_DIR} ${FLANG_SOURCE_DIR}/module/${filename}.f90
     DEPENDS flang-new ${FLANG_SOURCE_DIR}/module/${filename}.f90 ${depends}
----------------
awarzynski wrote:
> In LLVM Flang, `-J` is just an alias for `-module-dir`: https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Driver/Options.td#L4589-L4592. 
> 
> So, `-J ${FLANG_INTRINSIC_MODULES_DIR}` is identical to `-module-dir ${FLANG_INTRINSIC_MODULES_DIR} ` and hence this change is not needed.
Already removed in updated patch.  But I'm not sure that equating -J with -module-dir is the right thing to do in the Arm driver.  -J specifies a module search directory, while -module-dir specifies the single module output directory, yes?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110356/new/

https://reviews.llvm.org/D110356