[flang-commits] [PATCH] D110139: [flang] Change complex type define in runtime for clang-cl

[Michael Kruse via Phabricator via flang-commits]

Meinersbur added a comment.

pre-merge check fails because disk is full.



================
Comment at: flang/runtime/complex-reduction.h:23
 
-#ifdef _MSC_VER
+#if defined _MSC_VER && ! __clang_major__ >= 12
 typedef _Fcomplex float_Complex_t;
----------------
`!` has a higher precedence than `>=`

With "true" msvc, `__clang_major__ ` will not be defined and evaluate to 0, so it turns out to work. Still consider checking for whether `__clang_major__ ` is defined to make intention clear.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110139/new/

https://reviews.llvm.org/D110139