[flang-commits] [PATCH] D109905: [flang] More precise checks for NULL() operands

[Peter Klausler via Phabricator via flang-commits]

klausler added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:55-62
+    if (lhs && rhs) {
+      Tristate isDefined{semantics::IsDefinedAssignment(
+          lhs->GetType(), lhs->Rank(), rhs->GetType(), rhs->Rank())};
+      if (isDefined == Tristate::Yes) {
+        context_.Say(expr.source,
+            "Defined assignment statement is not "
+            "allowed in a WORKSHARE construct"_err_en_US);
----------------
PeteSteinfeld wrote:
> This change doesn't seem related to everything else (although it looks good).  Did you mean to include it?
Yes, I do.  It avoids a crash that I ran into while testing some earlier forms of my patch, and it seemed worth keeping to avoid having to change it again in the future.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109905/new/

https://reviews.llvm.org/D109905