[flang-commits] [PATCH] D109227: [flang] GET_COMMAND_ARGUMENT(LENGTH) runtime implementation

[Diana Picus via Phabricator via flang-commits]

rovka added inline comments.


================
Comment at: flang/runtime/command.cpp:14
 namespace Fortran::runtime {
-CppTypeFor<TypeCategory::Integer, 4> RTNAME(ArgumentCount)() {
+using LengthType = CppTypeFor<TypeCategory::Integer, 4>;
+
----------------
klausler wrote:
> I don't think that this is the right solution.  What if the LENGTH= argument to GET_COMMAND_ARGUMENT had been an INTEGER*8 variable?  That case should work.  It would be better to use a larger result type here.
Oh, I misunderstood, I thought we had agreed on the interface. 

I'll upload a new version with 8-byte integers next week, since right now I'm a bit busy with some side issues.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109227/new/

https://reviews.llvm.org/D109227