[flang-commits] [PATCH] D109107: [flang] Move runtime API headers to flang/include/flang/Runtime

[Jean Perier via Phabricator via flang-commits]

jeanPerier added inline comments.


================
Comment at: flang/test/Runtime/no-cpp-dep.c:11
 
-#include "entry-names.h"
+#include "flang/Runtime/entry-names.h"
 
----------------
I could reproduce the buildbot failure for this test.

This file is different from the others because it is not built by CMAKE, it is built by LIT with the command in the `RUN:`. So the `%runtimeincludes` definition in lit.cfg.py needs to be fixed [[ https://github.com/llvm/llvm-project/blob/d60a02201d96ed5311404991186d827869d7ac8b/flang/test/lit.cfg.py#L81 | here ]].

I guess you can decide between leaving this test untouched and replacing `runtime` by `include/flang/Runtime` in the lit.cfg.py, or keeping this change and replacing `runtime` by `include` in  the lit.cfg.py.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109107/new/

https://reviews.llvm.org/D109107