[flang-commits] [PATCH] D109048: [flang] COMMAND_ARGUMENT_COUNT runtime implementation

[Peter Klausler via Phabricator via flang-commits]

klausler added inline comments.


================
Comment at: flang/runtime/command.cpp:1
+//===-- runtime/command.cpp -------------------------------------*- C++ -*-===//
+//
----------------
I don't think that you need the "*- C++ *" stuff in *.cpp files, just in headers (*.h).


================
Comment at: flang/runtime/command.cpp:14
+CppTypeFor<TypeCategory::Integer, 4> RTNAME(ArgumentCount)() {
+  int argc = executionEnvironment.argc;
+  if (argc > 1) {
----------------
Braced initialization, please; it's often safer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109048/new/

https://reviews.llvm.org/D109048