[flang-commits] [PATCH] D114829: [flang] Adjust names in Semantics that imply too much (NFC)

[Peter Klausler via Phabricator via flang-commits]

klausler created this revision.
klausler added a reviewer: jeanPerier.
klausler added a project: Flang.
Herald added subscribers: mehdi_amini, jdoerfert.
klausler requested review of this revision.

Some kinds of Fortran arrays are declared with the same syntax,
and it is impossible to tell from a shape (:, :) or (*) whether
the object is assumed shape, deferred shape, assumed size, implied
shape, or whatever without recourse to more information about the
symbol in question.  This patch softens the names of some predicate
functions (IsAssumedShape to CanBeAssumedShape) and makes others
more reflective of the syntax they represent (isAssumed to isStar)
in an attempt to encourage coders to seek and find definitive
predicate functions whose names deliver what they seem to mean.

Address TODO comments in IsSimplyContiguous() by using the
updated IsAssumedShape() predicate.


https://reviews.llvm.org/D114829

Files:
  flang/include/flang/Evaluate/tools.h
  flang/include/flang/Semantics/symbol.h
  flang/include/flang/Semantics/type.h
  flang/lib/Evaluate/characteristics.cpp
  flang/lib/Evaluate/check-expression.cpp
  flang/lib/Evaluate/shape.cpp
  flang/lib/Evaluate/tools.cpp
  flang/lib/Lower/ConvertType.cpp
  flang/lib/Semantics/check-call.cpp
  flang/lib/Semantics/check-declarations.cpp
  flang/lib/Semantics/mod-file.cpp
  flang/lib/Semantics/resolve-names-utils.cpp
  flang/lib/Semantics/type.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114829.390854.patch
Type: text/x-patch
Size: 21849 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20211201/432e28fd/attachment-0001.bin>